Skip to content

Loosen import-time gate on Windows and unpin pytest#4532

Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
h-mayorquin:fix_ci_profiling
Apr 20, 2026
Merged

Loosen import-time gate on Windows and unpin pytest#4532
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
h-mayorquin:fix_ci_profiling

Conversation

@h-mayorquin
Copy link
Copy Markdown
Collaborator

The Profile imports on windows-latest job has been failing intermittently with single samples landing at 4-5.6 s against a 3.0 s per-sample threshold. We have no real evidence yet about whether these are isolated outliers from runner noise or a sustained slowdown, because import_test.py collects the per-sample data into a markdown table but raises the exception before printing it. I have raised the per-sample threshold to 6.0 s (with a TODO to lower it once we understand what is going on) and moved the table print above the raise so the per-sample distribution now reaches $GITHUB_STEP_SUMMARY even on failure. Let's collect evidence and I will come back after we accumulate some logs to see why it increased.

Bundled into the same change is a fix for the pytest 8.4 regression in build_job_summary.py: the slowest-durations block in pytest 8.4+ now contains a blank line and a (N durations < Xs hidden.) footer that crashed the float parser, so I added a regex filter that keeps only true duration rows. The filter is backward compatible with the older format, which lets us drop the pytest<8.4.0 pin in pyproject.toml. Closes #3965.

@h-mayorquin h-mayorquin self-assigned this Apr 20, 2026
@h-mayorquin h-mayorquin added the continuous integration Related to CI label Apr 20, 2026
@alejoe91 alejoe91 merged commit 8d3e274 into SpikeInterface:main Apr 20, 2026
11 of 15 checks passed
@h-mayorquin h-mayorquin deleted the fix_ci_profiling branch April 20, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pytest 8.4.0 breaking core test build summary

2 participants