Loosen import-time gate on Windows and unpin pytest#4532
Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom Apr 20, 2026
Merged
Loosen import-time gate on Windows and unpin pytest#4532alejoe91 merged 2 commits intoSpikeInterface:mainfrom
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
Conversation
alejoe91
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Profile imports on windows-latestjob has been failing intermittently with single samples landing at 4-5.6 s against a 3.0 s per-sample threshold. We have no real evidence yet about whether these are isolated outliers from runner noise or a sustained slowdown, becauseimport_test.pycollects the per-sample data into a markdown table but raises the exception before printing it. I have raised the per-sample threshold to 6.0 s (with a TODO to lower it once we understand what is going on) and moved the table print above the raise so the per-sample distribution now reaches$GITHUB_STEP_SUMMARYeven on failure. Let's collect evidence and I will come back after we accumulate some logs to see why it increased.Bundled into the same change is a fix for the pytest 8.4 regression in
build_job_summary.py: the slowest-durations block in pytest 8.4+ now contains a blank line and a(N durations < Xs hidden.)footer that crashed the float parser, so I added a regex filter that keeps only true duration rows. The filter is backward compatible with the older format, which lets us drop thepytest<8.4.0pin inpyproject.toml. Closes #3965.